Update Godot engine detection with Godot Boy#903
Update Godot engine detection with Godot Boy#903MichaelHinrichs wants to merge 3 commits intoSteamDatabase:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
After running changed rules in this pull request (this bot only tests rules.ini changes): Changed technologies: Engine.Godot 3189 apps still match. These apps now match: (15) 523630 1876280 2200690 2800490 3144730 3606900 3719900 3884910 3891190 3984130 4002180 4041270 4071380 4114490 4142580 Please confirm that all these changed apps are correct. |
akien-mga
left a comment
akien-mga
left a comment
There was a problem hiding this comment.
Seems ok, though it's pretty niche.
Godot Boy seems to be a GameBoy emulator extension for Godot, which basically lets users ship GameBoy games (ROMs I assume) using Godot. I assume most of those first-party games are made with GBStudio and thus it would likely make more sense for these games to be detected as made with GB Studio (but there's no marker of it in the depots), at least alongside Godot.
But I'm not against merging this, technically those games do use Godot in some capacity.
| Godot[] = (?:^|/)godot_boy\.windows\.x86_64\.dll$ | ||
| Godot[] = (?:^|/)libgodot_boy\.linux\.x86_64\.so$ |
There was a problem hiding this comment.
Could be simplified like the above checks:
| Godot[] = (?:^|/)godot_boy\.windows\.x86_64\.dll$ | |
| Godot[] = (?:^|/)libgodot_boy\.linux\.x86_64\.so$ | |
| Godot[] = (?:^|/)(?:lib)godot_boy |
There was a problem hiding this comment.
That being said if this can use globbing it might make sense to make it more specific like:
| Godot[] = (?:^|/)godot_boy\.windows\.x86_64\.dll$ | |
| Godot[] = (?:^|/)libgodot_boy\.linux\.x86_64\.so$ | |
| Godot[] = (?:^|/)(?:lib)godot_boy.*\.(?:dll|dylib|so)$ |
and likewise for godotsteam and steamsdk-godot extension libraries.
| godot_boy.linux.x86_64.dll | ||
| libgodot_boy.windows.x86_64.so | ||
| godot_boy.windows.x86_64 | ||
| godot_boy.linux.x86_64.so |
There was a problem hiding this comment.
With my suggestion above these tests won't be non-matching anymore, but I'm not sure there's much value in testing these which should never be found in the wild (unless someone explicitly renames their libs to confuse us).
There are a few matches here which are indeed using Godot, but not through this PR. E.g. https://steamdb.info/app/3606900/depots/ (detected through libgodotsteam) or https://steamdb.info/app/3719900/depots/ (detected through .pck and/or libgodotsteam). |
|
Yeah this doesn't quite seem worth it at the moment. |
4 participants
SteamDB app page links to a few games using this
https://steamdb.info/app/3404520
Brief explanation of the change
This game, and likely others, have only this library as evidence that they use Godot.